-
Notifications
You must be signed in to change notification settings - Fork 920
Add integration tests for the analytics adapter #22102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add integration tests for the analytics adapter #22102
Conversation
Pull Request Test Coverage Report for Build becfdad042b62ad2f0ae038e96b2a9cec4516f14Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…nto 481-add-unitintegration-tests-for-the-analytics-adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the methods:
- __construct
- set_analytics_4_module
- is_connected
If certain methods are not worth writing tests for please add ignore annotation.
src/dashboard/infrastructure/analytics-4/site-kit-analytics-4-adapter.php
Show resolved
Hide resolved
…tp-requests-to-site-kit-endpoints-when-on-our-own-rest-endpoints # Conflicts: # src/dashboard/infrastructure/search-console/site-kit-search-console-adapter.php
…own-rest-endpoints' into 481-add-unitintegration-tests-for-the-analytics-adapter
9fb1ae3
to
90719b8
Compare
90719b8
to
0e46ec9
Compare
…tead of using its classes
…o be refactored anyway
I'm not including a test for that case, because we're removing that function anyway here. When that PR is merged, I'll go back and do the appropriate changes |
bd71b78
to
13f30b7
Compare
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Site_Kit_Analytics_4_Adapter::set_analytics_4_module()
and theSite_Kit_Analytics_4_Adapter::get_analytics_4_module()
functions to facilitate testing - it shouldnt have an impact in the normal behavior of the class.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/481