Skip to content

Remove first-time indexation notice from Indexation.js and FTC indexation.js #22248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

JSCHLTE
Copy link

@JSCHLTE JSCHLTE commented May 8, 2025

Context

This PR removes the outdated first-time indexation notice from the plugin’s UI. The message previously referenced legacy features (Text Link Counter and Internal Linking Analysis) which have since been merged into the core indexation process.


Summary

Changelog label: changelog: non-user-facing

This PR can be summarized in the following changelog entry:

  • Removes the first-time indexation notice from Indexation.js and the First Time Configuration flow.

Relevant technical choices:

  • Deleted the renderFirstIndexationNotice() method in Indexation.js
  • Removed its conditional rendering
  • Ensured no duplicates existed in FTC's indexation.js
  • Verified yarn build and yarn lint passed for only the edited files

Test instructions

Acceptance testing steps:

  1. Run yarn build — it should succeed without errors related to these files.
  2. Run yarn lint — your changes should pass without CRLF errors.
  3. Confirm the following message is no longer shown:

    "This feature includes and replaces the Text Link Counter and Internal Linking Analysis"

  4. Check the First Time Configuration screen and Tools page — the notice should not appear.
  5. Check that no React or console errors appear due to missing method references.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes are JS-only — not post-type dependent
  • No editor integrations are affected
  • Browser-agnostic (React logic only)
  • Multisite not relevant

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR touches the indexation UI in both the Tools screen and FTC flow. It should be tested in both places to ensure the notice is gone and no JS errors occur from removed methods.


UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • Not applicable to Shopify

Documentation

  • Covered by inline comments and clear PR description

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have run yarn build and yarn lint.
  • I have verified the base branch is trunk.

Innovation

  • No innovation project is applicable for this PR.

Fixes #21689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the notice related to Text link counter and Internal linking analysis
2 participants