Skip to content

568 add guard to the loading scripts for features that are disabled in free #22268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented May 14, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds guard for enqueuing content analysis styling when content analysis feature is disabled.

Relevant technical choices:

  • AI generator and fix assessments styling will be remove by separate PR that introduces AI in free.
  • Removed out dated css that was added in this PR For the taxonomy overall score icon.
  • Removed outdated css for taxonomy overview page for seo title (not used).
  • Removed enququeing of language script in admin pages. Not needed. Only for editors.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoast SEO->Settings->Site features
  • Disable readability analysis
  • Edit a post in classic/block-editor/elementor .
  • View page source and check there are no styling starting with 'yst_seo_score-' enqueued.
  • Check the seo analysis and inclusive language analysis looks the same.
  • Edit a Term and repeat the above steps.
  • Edit a post and go to readability tab, click on the eye icon and check the text is highlighted in the editor.
  • Go to Yoast SEO->Settings->Site features
  • Disable SEO analysis, Readability analysis, Inclusive language analysis, Insights and cornerstone content.
  • Edit a post in classic/block-editor/elementor and edit a term and the the language script is not loaded, if you are testing in english them search for "yoast-seo-en-language-js".

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/568

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 14, 2025
vraja-pro added 4 commits May 14, 2025 20:15
Was added in this PR :#3105 For the previous design.
The icons are already available and the rest of the styles are outdated and removed.
@coveralls
Copy link

coveralls commented May 14, 2025

Pull Request Test Coverage Report for Build 8f7cceb1fa3474419825a75c6458e2dd4fccca80

Details

  • 7 of 21 (33.33%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 52.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/taxonomy/class-taxonomy.php 4 6 66.67%
admin/metabox/class-metabox.php 3 9 33.33%
src/integrations/third-party/elementor.php 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
admin/taxonomy/class-taxonomy-metabox.php 1 0.0%
Totals Coverage Status
Change from base Build 88257803bc6f7a58da4a102fb5dfc4ef74f7f98c: -0.5%
Covered Lines: 29117
Relevant Lines: 56514

💛 - Coveralls

@vraja-pro vraja-pro force-pushed the 568-add-guard-to-the-loading-scripts-for-features-that-are-disabled-in-free branch from 3fea9c8 to d395477 Compare May 15, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants