-
Notifications
You must be signed in to change notification settings - Fork 920
Use indexables for retrieving posts for the llms.txt file #22327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/25.4
Are you sure you want to change the base?
Use indexables for retrieving posts for the llms.txt file #22327
Conversation
78e89b5
to
b185889
Compare
b185889
to
ca5f49f
Compare
Pull Request Test Coverage Report for Build 73357a4236d45956f83bcf9af3a3df0566838edeDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 1 suggestion 1 comment.
$exclude_old = false; | ||
|
||
if ( $post_type === 'post' ) { | ||
$exclude_old = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this to exclude_older_than_one_year or something since that is what this does. I was very confused on what old
meant in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha fair enough, added here.
Context
Summary
This PR can be summarized in the following changelog entry:
noindex
ed posts from getting into the llms.txt file.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test preventing specifically
noindex
ed postsTest generating the llms.txt file where your most recently modified post is:
Allow search engines to show this content in search results
setting is set toyes
(or the default)## Posts
sectionAllow search engines to show this content in search results
setting is set tono
Test impact of the PR making indexables the source of truth:
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter)noindex
postsnoindex
ed. Make sure that post the most recently modified one.cornerstone
. Make sure that post is NOT in the 5 most recently modified ones.noindex
ed post exists in the former but not in the latterRelevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Post Lists
section of Add content in the llms.txt file #22257UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/613