Skip to content

Add tests to free sparks route #22334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vraja-pro
Copy link
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests to the free sparks rest route.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Copy link

github-actions bot commented Jun 9, 2025

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@vraja-pro vraja-pro added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed merge conflict labels Jun 9, 2025
@vraja-pro vraja-pro added this to the feature/ai-generator-in-free milestone Jun 9, 2025
@vraja-pro vraja-pro changed the base branch from trunk to feature/ai-generator-in-free June 9, 2025 16:02
@vraja-pro vraja-pro force-pushed the add-tests-to-free-sparks-route branch from f8026c0 to 251c324 Compare June 9, 2025 16:07
@coveralls
Copy link

coveralls commented Jun 9, 2025

Pull Request Test Coverage Report for Build 7bc999200f1f62f23f3d9165be65f5064bede6c3

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 51.586%

Totals Coverage Status
Change from base Build 10fb3593ad45832e05d8c88254e2ba7389d9fc85: -0.5%
Covered Lines: 29440
Relevant Lines: 58085

💛 - Coveralls

@igorschoester igorschoester self-assigned this Jun 10, 2025
And use `$this` instead of `self` like the other tests. Not sure why, but lets be consistent
@igorschoester igorschoester force-pushed the add-tests-to-free-sparks-route branch from 9464014 to 5aedabe Compare June 10, 2025 07:02
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit d183ebb into feature/ai-generator-in-free Jun 10, 2025
12 checks passed
@igorschoester igorschoester deleted the add-tests-to-free-sparks-route branch June 10, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants