feat: use expecto printer compat layer #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges This should reduce the need to coordinated updates, allowing YoloDev to remain unchanged even if the underlying TestPrinters signature changes Specifically, we plan to add an `isSkipped` parameter to the beforeEach printer. As-is, that change breaks YoloDev. This change should fix that
Contributor
Author
|
Looks like I just needed to update my Visual Studio to fix the project loading |
Alxandr
reviewed
Mar 2, 2025
farlee2121
force-pushed
the
printer-compat-layer
branch
from
7ad3b4f to
50a4da4
Compare
Alxandr
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186
The change
Use TestPrinters builder to insulate YoloDev from printer signature changes
This should reduce the need to coordinated updates, allowing YoloDev to remain unchanged even if the underlying TestPrinters signature changes
Specifically, we plan to add an
isSkippedparameter to the beforeEach printer.As-is, that change breaks YoloDev. This change should fix that
I tested Expecto 11.0.0-alpha8 with these changes locally, and it worked as expected
Problem
For unclear reasons, this change seems to have broken the YoloDev.Expecto.TestSdk project's ability to load in Visual Studio.It says
The SDK 'Microsoft.NET.Sdk' specified could not be found.