Skip to content

Conversation

@Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Jul 23, 2025

Similar to nunit/nunit3-vs-adapter#1262

Fixes microsoft/testfx#5096

It's too early to try to set IsTestingPlatformApplication in props. So moving to targets and cleaning things up.

FYI @Evangelink @nohwnd

@Youssef1313 Youssef1313 marked this pull request as ready for review July 23, 2025 10:20
@Evangelink
Copy link
Contributor

@Alxandr please let us know if you need more info.

@Alxandr
Copy link
Contributor

Alxandr commented Jul 23, 2025

<ProjectCapability Include="TestContainer" /> no longer needed?

@Youssef1313
Copy link
Contributor Author

@Alxandr
Copy link
Contributor

Alxandr commented Jul 23, 2025

Is this ready to be released immediately, or does it hinge on some new release of upstream?

@Alxandr Alxandr merged commit 909ac25 into YoloDev:main Jul 23, 2025
7 checks passed
@Youssef1313 Youssef1313 deleted the patch-1 branch July 23, 2025 13:49
@Youssef1313
Copy link
Contributor Author

It can be released if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary setting of defaults on xunit.net / nunit / (tunit?)

3 participants