Add missing comma causing implicit str concat#176
Open
EhsanKia wants to merge 1 commit intoYosysHQ:mainfrom
Open
Add missing comma causing implicit str concat#176EhsanKia wants to merge 1 commit intoYosysHQ:mainfrom
EhsanKia wants to merge 1 commit intoYosysHQ:mainfrom
Conversation
|
Any news |
Author
|
Yeah I'm not sure, there were 2 pull requests earlier this week that were accepted. This one is a trivial one-liner which is clearly a bug. |
Member
|
Sorry, its not as trivial as it looks as I need to check that there isn't reliance on the broken behaviour anywhere else. I will try and get to it though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found using a regex and is most likely a bug. The two adjacent strings get implicitly concatenated, which is not the right logic.