Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Some cells (e.g. $macc_v2) are marked evaluable, but will raise an abort if called with
CellTypes::eval().Explain how this is achieved.
Instead of falling through to the abort, we can pass a pointer to a boolean to check for errors. Use said check to catch
CellTypes::eval()errors and treat them as unevaluable but otherwise continue.Make sure your change comes with tests. If not possible, share how a reviewer might evaluate it.
Following script based on #5534:
Without this change this will call
log_abort(), with this change it will instead display warnings of unsupported cells but otherwise continue (I'm not sure if continuing is always the desired behaviour, but it is consistent with other cells marked evaluable but which don't fit one of the supported patterns).