This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Clean up Config.php and use isSetFlag method for boolean functions #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vmalyk
commented
Nov 15, 2019
vmalyk
commented
- Fixed getters for boolean params and used isSetFlag
- Fixed Default value to as more changes scope to ScopeInterface::SCOPE_STORE instead null
- Removed checking $this->isSingleStoreMode() - it`s handled by Magento framework
lgreenboim
reviewed
Apr 1, 2020
Contributor
lgreenboim
left a comment
lgreenboim
left a comment
There was a problem hiding this comment.
@vmalyk Thank you for the pull-request, but the commit is rejected as it might cause issues in single store mode.
Contributor
Author
|
@lgreenboim, thank you for checking. Can you provide details about issues? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.