fix: use PHPStan version >=2 for Pimcore projects #59
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youwe-petervanderwal
requested review from
Anve94,
DuckThom,
MartijnVanDoornik,
elzekool,
igorwulff,
kjkooistra-youwe,
leonhelmus,
rutgerrademaker,
umizoomi and
youwe-emre-can
|
Note: No CHANGELOG.md change on purpose, the
for upcoming version 3.0.0 covers it enough if you ask me |
youwe-petervanderwal
force-pushed
the
fix/phpstan-version-2
branch
from
b10a56c to
845ae2a
Compare
kjkooistra-youwe
approved these changes
Nov 3, 2025
youwe-petervanderwal
force-pushed
the
fix/phpstan-version-2
branch
from
845ae2a to
d36abe5
Compare
|
Created follow-up bug #60 because the problem is not fully resolved yet :( However, I do think it is a good idea to push to PHPStan version 2, also due to config differences which are then resolved. |
Bumping to version >=2 (for Pimcore only) and making PHPStan 2 related adjustments in phpstan.neon because PHPStan 1 vs 2 requires a slightly different configuration, and we prefer a default config that always works.
youwe-petervanderwal
force-pushed
the
fix/phpstan-version-2
branch
from
d36abe5 to
4d5ee86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to version >=2 (for Pimcore only) and making PHPStan 2 related
adjustments in phpstan.neon because PHPStan 1 vs 2 requires a slightly
different configuration, and we prefer a default config that always
works.