- 
                Notifications
    
You must be signed in to change notification settings  - Fork 11
 
fix: perform most operations in post-install-cmd #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: perform most operations in post-install-cmd #61
Conversation
| 
           Note: no CHANGELOG.md -- the bug itself is caused by changes that are done in the (not yet released) 3.0.0  | 
    
Error: Composer didn't correctly recognize newly installed packages Caused by: PackagesInstaller running in "post-package-install" Resolved with: Running (most) installers in "post-install-cmd" instead Resolves YouweGit#60
eca16ba    to
    ed0d747      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm contemplating whether it makes sense to increase the verbosity of the info logs since in terms of dev experience they don't appear to add much. Currently it's showing something might happen, e.g. $event->getIO()->write('<info>Running Youwe Testing Suite pre-installer</info>');, but that doesn't really add anything outside of debugging contexts.
The installer it's actually running would be more interesting, but if it's just a 'FileInstaller' then it doesn't add much either. Since it's a major version update anyway might make sense here to increase the verbosity to require -v flag since they do read like debugging messages already anyway. Plus, seems like composer already allows passing a flag to the IO write public function write($messages, bool $newline = true, int $verbosity = self::NORMAL); to update the verbosity
In the end I'm impartial though - just something to consider - so approved.
| 
           Regarding the verbosity @Anve94 It's a bit 'weird' if you ask me. At one point I do agree it could be a more hidden/verbose only message, on the other hand, composer outputs a lot of the operations it performs so in that sense the current implementation is in line with that...  
I also kinda like that you can see why a certain file was created by the composer operation  | 
    

Error: Composer didn't correctly recognize newly installed packages
Caused by: PackagesInstaller running in "post-package-install"
Resolved with: Running (most) installers in "post-install-cmd" instead
Resolves #60