feat: Add support for iOS#101
Open
Jurpp wants to merge 7 commits into
Open
Conversation
added 5 commits
July 20, 2021 16:13
…cked checkSettings() and requestResolutionSettings(), added section to example app for testing all exposed functions
Author
|
Unfortunately auto linking does not seem to be working yet. I will submit a new PR once fixed. |
…nd added xcode project
Author
|
Fixed with latest commit |
|
@Jurpp this PR allows to check if the location service is enabled? |
Author
|
@cinder92 No this won't do anything on iOS. It just ensures that your iOS build will not crash when using this library for the Android part of of your app. Currently when importing the library in your Javascript the iOS build crashes. |
|
@YsnKsy since it is fixing iOS crashes, could you please accept this merge request, please ? |
Marma92
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Library would break on iOS (see #88). As most people create their app in React Native to build for iOS and Android simultaneously I created a Pod for iOS to mock the native calls. Besides that I added a platform check to bypass the
addListenerandoncefunctions completely. The library now no longer crashes the iOS build.yarn example ioscan be used to start the example app in an iOS emulator. Linters and tests are passing.All we need to look at is whether autolinking is working correctly, the example app links the Pod manually at this moment.