Conversation
dacav
force-pushed
the
dacav/bio-drop-strict-ifs
branch
4 times, most recently
from
1873954 to
9b06040
Compare
LDVG
reviewed
Apr 7, 2026
dacav
force-pushed
the
dacav/bio-drop-strict-ifs
branch
from
9b06040 to
0180b8f
Compare
LDVG
reviewed
Apr 8, 2026
Contributor
LDVG
left a comment
LDVG
left a comment
There was a problem hiding this comment.
Did we accidentally revert the removed PIN/token check for fido_bio_dev_set_template_name()? 🙂
|
|
||
| /* If available, prefer cached PUAT */ | ||
| if ((puat = fido_dev_puat_blob(dev)) != NULL) | ||
| return fido_blob_set(token, puat->ptr, puat->len); |
Contributor
There was a problem hiding this comment.
We probably need to translate a potential -1 return value here to FIDO_ERR_INTERNAL?
Contributor
Author
There was a problem hiding this comment.
Ach, Pitfall!
I see that fido_blob_set() is violating the return value convention: should it return a boolean perhaps?
Thanks for spotting.
dacav
force-pushed
the
dacav/bio-drop-strict-ifs
branch
from
0180b8f to
f83ec82
Compare
dacav
force-pushed
the
dacav/bio-drop-strict-ifs
branch
from
f83ec82 to
e843355
Compare
The conditional invocation of bio_get_uv_token() is extracted from bio_tx() into a separate resolve_token(), which can be invoked from individual calling sites of bio_tx(). The logic is purposedly changed: resolve_token() will invoke bio_get_uv_token() even if PIN is NULL. Such operation might be successful if the Authenticator supports some form of UV.
The conditionals are too strict, since a form of UV might be supported by the Authenticator.
dacav
force-pushed
the
dacav/bio-drop-strict-ifs
branch
from
e843355 to
e09ff5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #960