Refactored NFCConnection in preparation of Swift 6 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jdmoreira
force-pushed
the
joao/nfc-connection-refactor
branch
from
11bd149 to
6586f21
Compare
jdmoreira
force-pushed
the
joao/nfc-connection-refactor
branch
from
6586f21 to
95784ac
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors NFC connection handling and related OATH session processing while removing an unused asynchronous mapping extension. Key changes include:
- Removal of the Sequence+Extensions.swift file which previously provided an asyncMap extension.
- Introduction of a new NFC logging protocol in Logger+Extensions.swift.
- Refactoring of OATH session code to replace asyncMap with a loop-based approach, along with corresponding updates in full-stack tests.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| YubiKit/YubiKit/Utilities/Sequence+Extensions.swift | Removed unused asyncMap extension. |
| YubiKit/YubiKit/Utilities/Logger+Extensions.swift | Added HasNFCLogger protocol to support NFC-specific logging. |
| YubiKit/YubiKit/OATH/OATHSession.swift | Replaced asyncMap with a for-loop to build credential-code pairs. |
| FullStackTests/Tests/OATHFullStackTests.swift | Updated OATH tests to adapt to the loop-based implementation. |
| FullStackTests/Tests/ConnectionFullStackTests.swift | Updated asynchronous logger calls to await the asynchronous method. |
jdmoreira
changed the title
jdmoreira
force-pushed
the
joao/nfc-connection-refactor
branch
from
386578d to
4bfa427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation to make the sdk build in Swift 6 it was needed to refactor the NFCConnection.
The new implementation wraps all the calls to CoreNFC in an actor. I verified this compiles without errors or warnings in Swift 6.1.
The end to end tests are all passing for this connection and I tried to keep the same api and throwing error semantics as before.
Similar to what was done in #20 for the SmartCardConnection
Extras