remove: DATE decomposition and retrospective mode#30
Merged
Conversation
The linear trend basis in DATE decomposition poses confounding risk with seasonal patterns, and the retrospective mode's treatment indicator approach lacks the theoretical guarantees of the original paper when applied through this library's implementation. Removed rather than warned to prevent misinterpretation of results. - Delete decomposition.py, retrospective.py and their tests - Remove decompose() method, mode parameter, _decomposition state - Remove "decomposition" plot metric and _plot_decomposition() - Remove DateDecomposition/EffectComponent from public API - Update all docs (api.md, theory.md, examples.md, README.md, etc.) - 375 tests pass, 0 regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.decompose(),DateDecomposition,EffectComponent) を完全削除mode="retrospective") を完全削除Changes
decomposition.py,retrospective.pyおよびテスト2ファイルを丸ごと削除（-1650行）main.py:mode引数、_decomposition、_run_retrospective()、decompose()削除plot.py:"decomposition"metric、_plot_decomposition()削除__init__.py:DateDecomposition,EffectComponentのexport削除test_horseshoe.py: retrospective mode テスト削除test_options.py,test_rust_sampler.py: コメント/テスト値更新api.md,theory.md,examples.md,compatibility-matrix.md,README.md,CHANGELOG.mdBreaking Changes
ci.decompose()はAttributeErrorになるmode="retrospective"はValueError: Unknown model_args keys: ['mode']になるfrom causal_impact import DateDecompositionはImportErrorになるTest plan
pytest tests/ -v)from causal_impact import CausalImpact, ModelOptions→ OKfrom causal_impact import DateDecomposition→ImportErrormode="retrospective"→ValueError