ci: add PR English check and translate AGENTS.md for Codex review#68
Conversation
Add pr-language job that checks PR title and body contain primarily ASCII characters (threshold: 30% non-ASCII fails). This enforces English-only PR descriptions for consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Translate root and subdirectory AGENTS.md files from Japanese to English for Codex automatic review compatibility. Add Review Guidelines sections for Codex to follow. CLAUDE.md remains in Japanese as the Claude Code instruction file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
documentation
There was a problem hiding this comment.
Pull request overview
This PR enforces English-only pull requests and translates agent instruction files for automated code review integration.
Changes:
- Adds CI job that rejects PRs with >30% non-ASCII characters in title/body
- Translates AGENTS.md files from Japanese to English across all directories
- Adds Review Guidelines sections to support OpenAI Codex automatic code review
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds pr-language job to enforce English-only PR titles and descriptions |
| AGENTS.md | Translates root agent instructions to English and adds review guidelines |
| worker/python/AGENTS.md | Translates Python worker instructions to English with review guidelines |
| internal/AGENTS.md | Translates internal package instructions to English with review guidelines |
| docs/AGENTS.md | Translates documentation guidelines to English with review guidelines |
| bench/AGENTS.md | Translates benchmark instructions to English with review guidelines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uv run ruff format --check . | ||
|
|
||
| # Type check | ||
| uv run ty check . |
There was a problem hiding this comment.
The command 'ty check' appears to be incorrect. Python type checking is typically done with 'mypy' or 'pyright'. This should likely be 'uv run mypy .' or 'uv run pyright .'.
| uv run ty check . | |
| uv run mypy . |
| | Metric | Target | Notes | | ||
| |--------|--------|-------| | ||
| | p50 | < 100us | Simple function call | | ||
| | p99 | < 500us | Includes GC and process overhead | |
There was a problem hiding this comment.
The Markdown table has duplicate pipe characters at the start of each line. Remove the leading pipe to fix the table formatting.
| | Metric | Target | Notes | | |
| |--------|--------|-------| | |
| | p50 | < 100us | Simple function call | | |
| | p99 | < 500us | Includes GC and process overhead | | |
| Metric | Target | Notes | | |
| --------|--------|-------| | |
| p50 | < 100us | Simple function call | | |
| p99 | < 500us | Includes GC and process overhead | |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c324cdfafd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (body.length > 0 && bodyRatio > threshold) { | ||
| issues.push(`PR body contains ${(bodyRatio * 100).toFixed(0)}% non-ASCII characters. Please use English.`); |
There was a problem hiding this comment.
The new body check uses bodyRatio on the full PR body, but this repository’s .github/PULL_REQUEST_TEMPLATE.md is a long ASCII template, so non-English descriptions can still pass because the template text dominates the denominator. I verified this against the current template: adding a Japanese summary to the default body keeps non-ASCII ratio well under 30%, which means the pr-language gate does not actually enforce English-only PR bodies in normal workflow.
Useful? React with 👍 / 👎.
Add GitHub Actions workflow for automated PR review using anthropics/claude-code-action. Runs on PR open/sync and @claude comments. Uses OAuth token (Pro/Max plan) to avoid API usage costs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
pr-languageCI job that fails when PR title/body contains >30% non-ASCII characters, enforcing English-only PRsTest plan
pr-languagejob passes on this PR (English title/body)🤖 Generated with Claude Code