add additional basePath attribute to allow changing the source of the… #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flags folder When the flags directory should not be directly in the root folder, eg. static asserts are wrapped in sub folder due to rewrite rules, an additional basePath should allow to address the flags correctly.
Trisky
added a commit
to Trisky/react-flagpack
that referenced
this pull request
Sep 8, 2025
This change is a companion change for Yummygum#86 and should only be merged with that change.
This was referenced Sep 8, 2025
|
Hi! I've created a merge request that replaces this one which includes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… flags folder
When the flags directory should not be directly in the root folder, eg. static asserts are wrapped in sub folder due to rewrite rules, an additional basePath should allow to address the flags correctly.