[autopatch] TEST BEFORE MERGE ynh_setup_source --full_replace=1#140
Open
Salamandar wants to merge 1 commit into
Open
[autopatch] TEST BEFORE MERGE ynh_setup_source --full_replace=1#140Salamandar wants to merge 1 commit into
Salamandar wants to merge 1 commit into
Conversation
Salamandar
force-pushed
the
testing
branch
3 times, most recently
from
June 5, 2024 12:44
6cbd098 to
1abfb51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic PR
This is an automated patch to potentially fix a bug in the upgrade script.
ynh_setup_sourcedoesn't overwrite the destination directory, but rather extracts the source in the existing directory.This might lead to weird cases where legacy source files aren't deleted.
The command has an argument
--full_replace=1that fixes this behaviour.BE CAREFUL because this change might lead to data losses! You should check that all the patches calls to
ynh_setup_sourcedo exactly what you expect to do and don't delete user data.
If you want exclude some files from being overwritten/deleted, use the
--keepargument, just like that: