Mail

[Thovi98]

Problem

Creating this pr for the record.

I’ve managed to make mails work nearly out of the box (#75).

The issue is that line sqlite3 $install_dir/app.db "UPDATE settings SET mail_password='$mail_pwd'" is not correct. It is rather the column mail_password_e that is used, but it is… encrypted. If I manually check the mail_pwd in /etc/yunohost/apps/calibreweb/settings.yml and set it through Calibreweb interface, mail works. But I think it’s to much hassle to try to encrypt ourselves with the same encryption tool as CW for this to work out of the box 😅

Solution

Leave things like now
Or don’t fill the mail_password_e column (mail_password can in any case be ditched), but mention in the ADMIN.md that the mail password is __MAIL_PWD__ (but I don’t know how secure it is to do so?)

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Krakinou]

Hi,
Thanks a lot for that!
Can you give a look at this hack used here.
I used it to encrypt the user password in the database before that the LDAP were integrated in the upstream : I think there is a good chance that the email hash used the same technic.

[Thovi98]

Thanks for your input, but from my tests it doesn’t generate the same encryption tool (did I do it right?).

For references, encryption seems to have been added from this commit, but I’m not enough familiar with this to know what to do next