Skip to content

Move install_dir/live/data to data_dir/data#118

Open
ericgaspar wants to merge 43 commits into
testingfrom
datadir
Open

Move install_dir/live/data to data_dir/data#118
ericgaspar wants to merge 43 commits into
testingfrom
datadir

Conversation

@ericgaspar
Copy link
Copy Markdown
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Copy Markdown
Member Author

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

May the CI gods be with you!
Test Badge

@ericgaspar
Copy link
Copy Markdown
Member Author

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

Alrighty!
Test Badge

@ericgaspar
Copy link
Copy Markdown
Member Author

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

🎠
Test Badge

@Salamandar
Copy link
Copy Markdown
Member

Uh but this would require a "migration" during an upgrade right ?

@lapineige lapineige mentioned this pull request Jun 3, 2024
2 tasks
@Salamandar Salamandar changed the title fix Move install_dir/live/data to data_dir/data Jun 14, 2024
Comment thread scripts/upgrade Outdated
#if [ -z "${password_hash:-}" ]; then
# password_hash=$(echo $($install_dir/galene-password-generator $password))
# ynh_app_setting_set --app=$app --key=password_hash --value="$password_hash"
#fi
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment those things ?

@ericgaspar
Copy link
Copy Markdown
Member Author

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

Living in the past, are we? 🐮👁️
Test Badge

@ericgaspar
Copy link
Copy Markdown
Member Author

!testme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants