Allows downloading files >1GB #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamentur
reviewed
Jun 26, 2020
conf/nginx-proxy.conf
Outdated
| proxy_set_header X-Forwarded-Port $server_port; | ||
|
|
||
| #allow downloading files >1GB | ||
| proxy_buffering off; |
Contributor
There was a problem hiding this comment.
WIth this options the include of the yunohost square won't work i think...
Contributor
There was a problem hiding this comment.
Suggested change
| proxy_buffering off; | |
| client_max_body_size 10G; |
Author
There was a problem hiding this comment.
In that case, I suggest considering a larger limit, like 100G, larger than a Blu-ray. I added a new commit.
Apparently proxy_buffering is needed for the yunohost square
Contributor
|
The PR #37 allow the user to specify the limit needed (in order to avoid security issues related to put the value systematically too high). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.