Explain that SSO headers are set only if the associated app permissio… #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
reviewed
Aug 15, 2025
| This documentation apply to YunoHost\>=12. On YunoHost \<12 the header was a bit different but the idea was the same. | ||
|
|
||
| Internally, SSOwat will on-the-fly inject theses different headers: | ||
| Internally, SSOwat will on-the-fly inject theses different headers, if the `resources.main.auth_header` permission is set to true in the app's manifest: |
Contributor
There was a problem hiding this comment.
Hmm, true for all of them except for the Basic Auth Header, isn't it?
Contributor
There was a problem hiding this comment.
Oh, I reconsider what I say above, my apologies 🤐.
You may actually be right, even the Basic Auth header may require that permission if I understand this test:
https://github.com/YunoHost/yunohost/blob/477bf84bf40cae532da7b152ba766a072046b3a2/tests/test_sso_and_portalapi.py#L316-L331
I let a well-informed reviewer confirm that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n is set
Problem
Solution
PR checklist