Make app restore more easy to debug with no-remove-on-failure option #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josue-T
changed the title
zamentur
reviewed
Sep 22, 2025
alexAubin
reviewed
Sep 22, 2025
Co-authored-by: Alexandre Aubin <[email protected]>
|
Tested by with an app which fail and success on restore and with and without option |
Salamandar
approved these changes
Sep 25, 2025
|
Can you just squash your two commits ? Then let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
We have a possibility to avoid to remove the app if the app install fail. It's really useful for debuging. For app restore we don't have it and it could be not easy to understand why the restore fail when the app are removed.
Solution
Add the same feature than for app install.
PR Status
Ready but not tested at all.
How to test
Try app restore of app which fail on restore.