Use focusInline from getSelection(), not value, when blocking select#4
Open
justinweiss wants to merge 1 commit into
Open
Use focusInline from getSelection(), not value, when blocking select#4justinweiss wants to merge 1 commit into
justinweiss wants to merge 1 commit into
Conversation
At the time `onSelect` is called on a plugin, `change.value.selection` hasn't been updated with the new selection. Since we block onSelect based on `change.value.selection.focusInline`, this means that you can end up blocking selection incorrectly in the following case: 1. Select an inline that's 3 characters long 2. Select character 3 of any other node 3. Watch as change.value.selection isn't updated with the new cursor position This change relies on `window.getSelection()` for every check, and double-checks `focusInline.key`, ensuring that we'll update the selection when clicking on a different node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time
onSelectis called on a plugin,change.value.selectionhasn't been updated with the new selection. Since we block onSelect based onchange.value.selection.focusInline, this means that you can end up blocking selection incorrectly in the following case:Here's an example:
This change relies on
window.getSelection()for every check, and double-checksfocusInline.key, ensuring that we'll update the selection when clicking on a different node.