Skip to content

Move reducedMotion to PageOption #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

Move reducedMotion to PageOption #102

merged 3 commits into from
Apr 7, 2025

Conversation

ngan
Copy link
Contributor

@ngan ngan commented Apr 6, 2025 •
edited
Loading

This is a fix for #100. The reducedMotion option is a PageOption, not BrowserOption.

For anyone blocked by this, you can add this to your playwright initialization:

Capybara::Playwright::PageOptions::NEW_PAGE_PARAMS.push(:reducedMotion)
Capybara::Playwright::BrowserOptions::LAUNCH_PARAMS.delete(:reducedMotion)

@ngan ngan changed the title Add reducedMotion to PageOption Move reducedMotion to PageOption Apr 6, 2025
@ngan
Copy link
Contributor Author

ngan commented Apr 6, 2025

@YusukeIwaki apologies but I made a mistake in my original PR. I think this also means that capybara-playwright-driver 0.5.5 is broken. 😢

@YusukeIwaki YusukeIwaki merged commit d276500 into YusukeIwaki:main Apr 7, 2025
12 checks passed
@ngan ngan deleted the fix-reduce-motion branch April 8, 2025 02:11
@YusukeIwaki
Copy link
Owner

@ngan Thank you. Now 0.5.6 is released and it fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YusukeIwaki YusukeIwaki YusukeIwaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngan @YusukeIwaki