Skip to content

Conversation

@maciesielka
Copy link
Contributor

Fixes #88

This is a regression from #86, which is too wide-reaching in upper-casing keys combined with Shift. Instead, only explicitly uppercase the individual a-z keys that require it.

@maciesielka
Copy link
Contributor Author

An interesting failure given how specific the changeset is in this PR:

rspec './vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/spec/spec_helper.rb[1:5:8]' # Capybara::Session Playwright #all should not reload by default

Any ideas?

@gma
Copy link

gma commented Dec 19, 2024

Any ideas?

I just tried running the tests on main locally, and they failed (on a different test). My plan was to try and reproduce the failing test you got on this branch once they'd all passed on main.

I didn't find any docs in the repo on how to install Playwright for development, so just installed a recent version in the project directory with:

npm install playwright --save-dev
npx playwright install chromium

Not sure if I've got an incompatible version there, or not?

I suspect we might need some advice from somebody more familiar with working on the project.

@maciesielka
Copy link
Contributor Author

@YusukeIwaki any thoughts about how to proceed?

@YusukeIwaki YusukeIwaki merged commit b114005 into YusukeIwaki:main Dec 21, 2024
10 of 11 checks passed
@YusukeIwaki
Copy link
Owner

@maciesielka Thank you for your contribution!
Now capybara-playwright-driver v0.5.4 is available with this fix. Please try it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#86 broke send_keys with shift plus special keys

3 participants