euf_seq_plugin: root-canonical simplification fixes + loop bound overflow guard#9744
Draft
Copilot wants to merge 3 commits into
Draft
euf_seq_plugin: root-canonical simplification fixes + loop bound overflow guard#9744Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix correctness and robustness issues in euf_seq_plugin
euf_seq_plugin: root-canonical simplification fixes + loop bound overflow guard
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
euf_seq_pluginwas applying several regex concat simplifications against raw child enodes instead of canonical e-graph roots, so rules could silently miss after merges. It also merged loop bounds with unchecked unsigned addition, allowing overflowed bounds.Root-canonical checks in simplification rules
get_root()for nullable/full-seq absorption checks.same_star_bodyto testis_staron roots and compare rooted star bodies.v*.v*.c/c.v*.v*) against concat roots, not syntactic children.Safe loop merge arithmetic
re.loop.Re-simplify concats affected by child merges
propagate_merge, re-runpropagate_simplifyfor tracked concat nodes whose left/right child root is in the merged class, not only concats in the class itself.Regression coverage in
src/test/euf_seq_plugin.cpp