Fix issue #821#823
Closed
Adrian-Devries wants to merge 13 commits into
Closed
Conversation
Contributor
Author
|
All test cases succeed. Find log files attached (FixIssue#827-Logs.zip). |
Contributor
Author
|
All test cases succeed. Find log files attached (07-KeepCompilableWithXerces-Logs.zip). |
Contributor
Author
|
All test cases succeed. Find log files attached: |
Contributor
Author
|
All test cases succeed. Find log files attached: |
Collaborator
|
please fix one issue at a time with one PR, sorry, that's too big and too risky for me given the painI've had with pom changes oin the past (and the fact that it seems to fail tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issue has been reported: #821
This pull request fixes the issue.
First, it fixes maven warnings by modifying the POM files. A minimalist approach has been applied. Find log files with maven warnings attached (FixMavenWarnings-Logs.zip).
Second, it fixes an issue with the ZF2EdgeTest that has been introduced with 2.16.4. No efforts have been taken to find the root cause of this issue. Just some assertions have been changed and a TODO comment has been added.
Third, it adds a test case for validation log visualization.
Fourth, it fixes the issue by adding a private method
setFeaturewhich encapsulates all attempts to set a TransformerFactory feature. Warnings for unsupported features will be generated, but exceptions would be avoided.This way, validation logs for all XML invoices that exist in the validator test resources could be visualized.
All test cases succeed. Find log files attached (FixIssue#821-Logs.zip).