Fix Start-of-Quarter Bugs For First Day Of Quarter #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- startOfThisCalendarQuarter(): Use Date instead of Datetime to avoid timezone issues when calling .month() (Date.month() returns the date's month directly, while Datetime.month() returns the month in the user's local timezone) - startOfthisFiscalQuarter(): Change < to <= in while loop to correctly handle quarter boundaries when today is the first day of a quarter
Contributor
Author
|
Today is January 1, 2026. Without the fixes: With the fixes: |
Owner
|
Appreciate it! I saw the unit tests fail on the 1st and figured it was a date/time issue - glad to see someone else was already on it! Just pushed this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startOfThisCalendarQuarter(): Use Date instead of Datetime to avoid timezone issues when calling .month() (Date.month() returns the date's month directly, while Datetime.month() returns the month in the user's local timezone)
startOfthisFiscalQuarter(): Change < to <= in while loop to correctly handle quarter boundaries when today is the first day of a quarter