feature/comparable-service-refactor #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proved clarity and type safety
…proved clarity and usability
…ip handling and update method signature in ComparableService class for consistency
…ieving comparable records
…meter and adjust instantiation in ComparableService
…er pattern for instantiation
…n and improve readability
…implify field retrieval logic
…ParentRecordLookup and update logic; add unit tests for ComparableService
…remove redundant setter in ComparableService
…rvice to utilize it; introduce ParentLookupResolver for field lookup chain handling
…s modifiers of finalField and fieldParts to private
…arableService to utilize new resolver for field lookup chain handling
…from findParentRecordAndRelationshipName; streamline comparable record handling
…g; consolidate logic in findParentRecordAndRelationshipName and improve builder usage
…dData; streamline parent record retrieval and enhance data encapsulation
…descriptions and builder pattern for improved usability
…eliminate redundant variable declaration and improve clarity in isPolymorphic handling
…ble; streamline comparable field retrieval using lookupChain
…able record retrieval; streamline method parameters and enhance clarity in parent record handling
…place redundant database call with direct access to parentRecord
…ring' to 'inherited sharing' for improved access control
…ement block in constructor
…nt with parentInfo.getParentRecord() for improved clarity in record retrieval
… and streamline comparable record assignment for improved clarity
…al scope for improved clarity and reduced class-level state
…mproved clarity in record retrieval
…mproved accuracy in record retrieval
…kup chain handling and remove redundant method
…d streamline field assignment
… for improved clarity in record handling
…roved parent record retrieval
…ed clarity and consistency; update QueriedFieldResolver to utilize new exception methods and enhance relationship mapping logic
…andler; enhance QueriedFieldResolver and MockSOQLHandler for improved processing logic
…ndler for improved clarity in handling filter logic
…egateQueryHandler for improved clarity in handling filter and grouping logic
…ockAggregateQueryHandler for consistency; update method calls accordingly
…y in MockAggregateQueryHandler
…; enhance ComparableServiceTest for improved coverage
… introduce ParentRecordDataWithRelationshipMapping for better structure and clarity
…s method inside ParentRecordDataWithRelationshipMapping for better encapsulation
…ng; consolidate logic and remove unnecessary class for improved clarity and maintainability
…ntExceptions; improve error handling for invalid field names, null arguments, and incorrect date/time formats
…ied fields; validate field lookup for Contact records
…st for QueriedFieldResolver to validate parent field retrieval across multiple levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…proved clarity and type safety