Skip to content

fix(linux): resolve system audio device by stripping ' (System Audio)' display suffix #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
90sRehem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(linux): resolve system audio device by stripping ' (System Audio)' display suffix #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions frontend/src-tauri/src/audio/devices/configuration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,20 @@ pub async fn get_device_and_config(

#[cfg(target_os = "linux")]
{
// For Linux, we use PulseAudio monitor sources for system audio
// For Linux, we use PulseAudio monitor sources for system audio.
// Monitor sources are listed with a " (System Audio)" display suffix
// (see configure_linux_audio); strip it before matching the raw
// cpal device name, mirroring the "(input)"/"(output)" stripping
// done in AudioDevice::from_name.
let raw_name = audio_device
.name
.trim_end_matches(" (System Audio)")
.to_string();

if let Ok(pulse_host) = cpal::host_from_id(cpal::HostId::Alsa) {
for device in pulse_host.input_devices()? {
if let Ok(name) = device.name() {
if name == audio_device.name {
if name == raw_name {
let default_config = device
.default_input_config()
.map_err(|e| anyhow!("Failed to get default input config: {}", e))?;
Expand Down