Skip to content

test(parakeet): add regression test for nested Downloading status - #766

Open
santhiprakash wants to merge 2 commits into
Zackriya-Solutions:devtestfrom
santhiprakash:fix/parakeet-nested-progress
Open

test(parakeet): add regression test for nested Downloading status#766
santhiprakash wants to merge 2 commits into
Zackriya-Solutions:devtestfrom
santhiprakash:fix/parakeet-nested-progress

Conversation

@santhiprakash

@santhiprakash santhiprakash commented Sep 4, 2026

Copy link
Copy Markdown

Description

The nested { Downloading: { progress } } status shape is already present on devtest after recent upstream parakeet work. This PR resolves the resulting merge conflict in ParakeetModelManager.tsx (upstream added the isCancelling prop and clearCancellingModel handling) and keeps the regression test in frontend/tests/lib/parakeet.test.tsx so the NaN% UI failure cannot silently return.

Related Issue

Fixes #742

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test

Testing

  • Added frontend/tests/lib/parakeet.test.tsx — render-level SSR test that mounts ModelCard with a nested Downloading status and asserts the output contains a real percent (42%) and no NaN%.
  • bun test tests/lib/parakeet.test.tsx — passes.
  • bun test tests/lib/ — 18 pass, 0 fail.
  • npx tsc --noEmit --project tsconfig.json — passes for all src/**/*.ts{,x} files; the existing tests/lib/*.test.* files (including this one) cannot resolve bun:test types because bun-types is not currently configured in the project. This is a pre-existing test-only types limitation, not a regression from this change.
  • bun run lint / next lint still cannot be completed because the repo's ESLint setup references @eslint/eslintrc but eslint and that package are not present in the installed dependencies.

Documentation

  • Documentation updated
  • No documentation needed

Checklist

  • Code follows project style
  • Self-reviewed the code
  • Added comments for complex code (not needed)
  • Updated README if needed
  • Branch is up to date with devtest
  • Merge conflict resolved

Screenshots (if applicable)

N/A — the only UI-visible change is the progress bar/percent rendering a real number instead of NaN%.

Additional Notes

  • Problem: ParakeetModelManager previously read model.status.Downloading as a number when the backend sent {"Downloading":{"progress":N}}, producing NaN% and NaNMB.
  • Current devtest already emits and consumes the nested { Downloading: { progress } } shape.
  • This PR preserves the regression test added in test(parakeet): add regression test for nested Downloading status #766 and updates its ModelCard props for the new isCancelling field.

@safvanatzack

Copy link
Copy Markdown
Collaborator

@santhiprakash Thanks for the contribution. We’re currently working through several other PRs and will take a closer look at this one when we reach it. Appreciate you directly addressing an existing issue.

@santhiprakash

Copy link
Copy Markdown
Author

Thanks @safvanatzack — no rush at all. Happy to address anything that comes up when you get to the review.

@santhiprakash santhiprakash changed the title fix(parakeet): align TypeScript Downloading status with Rust nested shape test(parakeet): add regression test for nested Downloading status Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants