test(parakeet): add regression test for nested Downloading status - #766
Open
santhiprakash wants to merge 2 commits into
Open
test(parakeet): add regression test for nested Downloading status#766santhiprakash wants to merge 2 commits into
santhiprakash wants to merge 2 commits into
Conversation
Collaborator
|
@santhiprakash Thanks for the contribution. We’re currently working through several other PRs and will take a closer look at this one when we reach it. Appreciate you directly addressing an existing issue. |
Author
|
Thanks @safvanatzack — no rush at all. Happy to address anything that comes up when you get to the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The nested
{ Downloading: { progress } }status shape is already present ondevtestafter recent upstream parakeet work. This PR resolves the resulting merge conflict inParakeetModelManager.tsx(upstream added theisCancellingprop andclearCancellingModelhandling) and keeps the regression test infrontend/tests/lib/parakeet.test.tsxso theNaN%UI failure cannot silently return.Related Issue
Fixes #742
Type of Change
Testing
frontend/tests/lib/parakeet.test.tsx— render-level SSR test that mountsModelCardwith a nestedDownloadingstatus and asserts the output contains a real percent (42%) and noNaN%.bun test tests/lib/parakeet.test.tsx— passes.bun test tests/lib/— 18 pass, 0 fail.npx tsc --noEmit --project tsconfig.json— passes for allsrc/**/*.ts{,x}files; the existingtests/lib/*.test.*files (including this one) cannot resolvebun:testtypes becausebun-typesis not currently configured in the project. This is a pre-existing test-only types limitation, not a regression from this change.bun run lint/next lintstill cannot be completed because the repo's ESLint setup references@eslint/eslintrcbuteslintand that package are not present in the installed dependencies.Documentation
Checklist
devtestScreenshots (if applicable)
N/A — the only UI-visible change is the progress bar/percent rendering a real number instead of
NaN%.Additional Notes
ParakeetModelManagerpreviously readmodel.status.Downloadingas a number when the backend sent{"Downloading":{"progress":N}}, producingNaN%andNaNMB.devtestalready emits and consumes the nested{ Downloading: { progress } }shape.ModelCardprops for the newisCancellingfield.