overall improvements from ValidUSA fork #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Huge amount of failed tests. These changes break |
Zatvobor
added
Regression
PR Pending
and removed
Needs Bug Verification
Needs Code Review
labels
Owner
Author
There was a problem hiding this comment.
what the reason for that?
There was a problem hiding this comment.
We had a need for strict schema in our files, and the original added a new "rev" attribute to the document.
There was a problem hiding this comment.
I just wanted to use _rev and not rev, it looked like they would always be equal at this point so I delete it from the json. Does rev need to be there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.