Skip to content

Conversation

@conradoplg
Copy link
Contributor

Closes #688

Based on #937, that needs to be merged before this is merged

@conradoplg conradoplg linked an issue Dec 3, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (5a27016) to head (94dde87).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   77.39%   77.39%           
=======================================
  Files          41       41           
  Lines        4503     4503           
=======================================
  Hits         3485     3485           
  Misses       1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix-zero-serialization-secret-package to main December 22, 2025 12:49
@natalieesk natalieesk self-assigned this Dec 22, 2025
@natalieesk natalieesk self-requested a review December 22, 2025 13:24
@natalieesk natalieesk removed their assignment Dec 22, 2025
natalieesk
natalieesk previously approved these changes Dec 22, 2025
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@conradoplg conradoplg force-pushed the serialization-roundtrips branch 2 times, most recently from a39e3af to ebb8864 Compare December 22, 2025 14:16
@conradoplg conradoplg force-pushed the serialization-roundtrips branch from ebb8864 to 94dde87 Compare December 22, 2025 14:32
@mergify mergify bot added the queued label Dec 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2025

Merge Queue Status

✅ The pull request has been merged at 94dde87

This pull request spent 4 minutes 6 seconds in the queue, including 1 second running CI.
The checks were run on draft #980.

Required conditions to merge

mergify bot added a commit that referenced this pull request Dec 22, 2025
@mergify mergify bot merged commit 8f60e6d into main Dec 22, 2025
22 checks passed
@mergify mergify bot deleted the serialization-roundtrips branch December 22, 2025 14:53
@mergify mergify bot removed the queued label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add checks for serialization round trips during tests

2 participants