Skip to content

Conversation

@kwsantiago
Copy link
Contributor

Closes #986

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added the queued label Jan 6, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2026

Merge Queue Status

✅ The pull request has been merged at 56b81ca

This pull request spent 3 minutes 53 seconds in the queue, including 2 seconds running CI.
The checks were run on draft #988.

Required conditions to merge

mergify bot added a commit that referenced this pull request Jan 6, 2026
@mergify mergify bot merged commit 504ef20 into ZcashFoundation:main Jan 6, 2026
19 checks passed
@mergify mergify bot removed the queued label Jan 6, 2026
@kwsantiago kwsantiago deleted the implement-zeroize-signing-nonces branch January 6, 2026 14:13
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.45%. Comparing base (59b4dbd) to head (56b81ca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   77.39%   77.45%   +0.06%     
==========================================
  Files          41       41              
  Lines        4503     4503              
==========================================
+ Hits         3485     3488       +3     
+ Misses       1018     1015       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kwsantiago
Copy link
Contributor Author

@conradoplg Thank you.

When will the next release be made that will include the changes in this PR and #945?

@conradoplg
Copy link
Contributor

@conradoplg Thank you.

When will the next release be made that will include the changes in this PR and #945?

Soon-ish, this week or the next one at most

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Zeroize for SigningNonces

2 participants