feat: Network Sustainability Mechanism - ZIP-234 implementation#10646
Open
judah-caruso wants to merge 2 commits into
Open
feat: Network Sustainability Mechanism - ZIP-234 implementation#10646judah-caruso wants to merge 2 commits into
judah-caruso wants to merge 2 commits into
Conversation
Contributor
|
Thanks, we will take a look |
hilljessica8787-dot
approved these changes
Jul 14, 2026
jvff
self-requested a review
July 23, 2026 19:59
jvff
requested changes
Jul 23, 2026
jvff
left a comment
Contributor
There was a problem hiding this comment.
I can't update the branch because I don't have permission to push to the branch in order to resolve conflicts.
| Network::Testnet(_) => &testnet::FOUNDER_ADDRESS_LIST, | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: formatting should remove the empty line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements ZIP-234; the changes were originally part of #8948.
Additionally, it implements an alternate version of ZIP-234 that preserves halvings (behind a separate
zip234altcfg-flag). Only one implementation can be enabled at once; enabling both flags will cause a compilation error.Reasoning for separate PRs is here: #8948 (comment)
AI Disclosure
PR Checklist