Skip to content

feat: Network Sustainability Mechanism - ZIP-234 implementation#10646

Open
judah-caruso wants to merge 2 commits into
ZcashFoundation:mainfrom
ShieldedLabs:zip-234
Open

feat: Network Sustainability Mechanism - ZIP-234 implementation#10646
judah-caruso wants to merge 2 commits into
ZcashFoundation:mainfrom
ShieldedLabs:zip-234

Conversation

@judah-caruso

Copy link
Copy Markdown
Contributor

Motivation

This PR implements ZIP-234; the changes were originally part of #8948.

Additionally, it implements an alternate version of ZIP-234 that preserves halvings (behind a separate zip234alt cfg-flag). Only one implementation can be enabled at once; enabling both flags will cause a compilation error.

Reasoning for separate PRs is here: #8948 (comment)

AI Disclosure

  • No AI tools were used in this PR
  • AI tools were used:
    • Claude for test boilerplate and general spec correctness

PR Checklist

  • The PR name is suitable for the release notes.
  • The PR follows the contribution guidelines.
  • This change was discussed in an issue or with the team beforehand.
  • The solution is tested.
  • The documentation and changelogs are up to date.

@judah-caruso judah-caruso changed the title Network Sustainability Mechanism - 234 implementation feat: Network Sustainability Mechanism - ZIP-234 implementation May 28, 2026
@natalieesk

Copy link
Copy Markdown
Contributor

Thanks, we will take a look

@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Jun 10, 2026
@jvff
jvff self-requested a review July 23, 2026 19:59

@jvff jvff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't update the branch because I don't have permission to push to the branch in order to resolve conflicts.

Network::Testnet(_) => &testnet::FOUNDER_ADDRESS_LIST,
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: formatting should remove the empty line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants