bumped curv-kzen to 0.10 + Upgraded code to compile#214
Open
gdnathan wants to merge 1 commit intoZenGo-X:masterfrom
Open
bumped curv-kzen to 0.10 + Upgraded code to compile#214gdnathan wants to merge 1 commit intoZenGo-X:masterfrom
gdnathan wants to merge 1 commit intoZenGo-X:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped curv-kzen to 0.10.
Notable changes to files:
VerifiableSStakes a second generic parameterH: Digest + Clone, I used sha2::Sha256 as this generic parameter, as thecurv-kzenlib doesVerifiableSSalso takes a new "proof" field. As there is no default, I copied the logic from one of the files ofcurv-kzenand did this:Sha256implement neitherSerializenorDeserialize, some of the tests doesn't pass anymore. I commented them out until we find a solution. If you have any required change, or any advice on how to fix the deserialize/serialize issue, please tell me.