[cli] deploy benchmarks with optimize: "cycles"

[ZenVoich]

fixes #284

Summary by CodeRabbit

• New Features
  • Added an optimization setting to the canister configuration when specifying a canister name.

[coderabbitai]

Walkthrough

A new property, optimize: 'cycles', is added to the canister configuration object returned by the dfxJson method in the BenchReplica class, specifically when a canisterName is provided. No other logic or public interfaces are changed.

Changes

File(s)	Change Summary
cli/commands/bench-replica.ts	Adds optimize: 'cycles' to the canister config object in the dfxJson method when applicable.

Poem

In the warren of code, a new path appears,
With cycles to optimize, the intent is clear.
BenchReplica now knows a trick up its sleeve,
For canisters named, new configs it weaves.
Hop, hop, hooray! The cycles are here!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ce28967 and b354590.

📒 Files selected for processing (1)

• cli/commands/bench-replica.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Run Benchmarks and Comment
• GitHub Check: node 20, moc 0.11.1, [email protected]

🔇 Additional comments (1)

cli/commands/bench-replica.ts (1)

96-96: LGTM: Adding cycle optimization for benchmarking.

This addition of optimize: 'cycles' to the canister configuration is appropriate for benchmark deployments, as it instructs the Internet Computer to optimize the canister for cycle consumption, which can be beneficial for performance benchmarking scenarios.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Benchmark Results

bench/1-buffer-vector-add.bench.mo $({\color{red}+2.16\%})$

Add (second)

Add items one-by-one (second)

Instructions: ${\color{red}+2.16\%}$
Heap: ${\color{gray}0\%}$
Stable Memory: ${\color{gray}0\%}$
Garbage Collection: ${\color{gray}0\%}$

Instructions

	10	10000	1000000
Buffer	10_589 $({\color{green}-22.08\%})$	6_204_478 $({\color{gray}0\%})$	573_081_816 $({\color{gray}0\%})$
Vector	15_416 $({\color{red}+35.04\%})$	4_909_875 $({\color{gray}0\%})$	468_132_811 $({\color{gray}0\%})$

Heap

	10	10000	1000000
Buffer	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$
Vector	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$

Garbage Collection

	10	10000	1000000
Buffer	1.09 KiB $({\color{gray}0\%})$	143.28 KiB $({\color{gray}0\%})$	12.02 MiB $({\color{gray}0\%})$
Vector	1.09 KiB $({\color{gray}0\%})$	45.65 KiB $({\color{gray}0\%})$	3.86 MiB $({\color{gray}0\%})$

bench/2-vector-buffer-add.bench.mo $({\color{gray}0\%})$

Add

Add items one-by-one

Instructions: ${\color{gray}0\%}$
Heap: ${\color{gray}0\%}$
Stable Memory: ${\color{gray}0\%}$
Garbage Collection: ${\color{gray}0\%}$

Instructions

	10	10000	1000000
Vector	15_416 $({\color{gray}0\%})$	4_910_243 $({\color{gray}0\%})$	468_155_259 $({\color{gray}0\%})$
Buffer	10_589 $({\color{gray}0\%})$	6_203_374 $({\color{gray}0\%})$	573_078_872 $({\color{gray}0\%})$

Heap

	10	10000	1000000
Vector	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$
Buffer	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$

Garbage Collection

	10	10000	1000000
Vector	1.09 KiB $({\color{gray}0\%})$	45.65 KiB $({\color{gray}0\%})$	3.86 MiB $({\color{gray}0\%})$
Buffer	1.09 KiB $({\color{gray}0\%})$	143.28 KiB $({\color{gray}0\%})$	12.02 MiB $({\color{gray}0\%})$

bench/array.bench.mo $({\color{gray}0\%})$

Array

arr arr

Instructions: ${\color{gray}0\%}$
Heap: ${\color{gray}0\%}$
Stable Memory: ${\color{gray}0\%}$
Garbage Collection: ${\color{gray}0\%}$

Instructions

	100k x1	reset1	100k x3	reset2	100k x4	reset3
Array	15_002_649 $({\color{gray}0\%})$	4_455 $({\color{gray}0\%})$	30_004_139 $({\color{gray}0\%})$	5_073 $({\color{gray}0\%})$	60_005_196 $({\color{gray}0\%})$	5_691 $({\color{gray}0\%})$

Heap

	100k x1	reset1	100k x3	reset2	100k x4	reset3
Array	390.9 KiB $({\color{gray}0\%})$	-390.37 KiB $({\color{gray}0\%})$	390.9 KiB $({\color{gray}0\%})$	-390.37 KiB $({\color{gray}0\%})$	390.9 KiB $({\color{gray}0\%})$	-390.37 KiB $({\color{gray}0\%})$

Garbage Collection

	100k x1	reset1	100k x3	reset2	100k x4	reset3
Array	360 B $({\color{gray}0\%})$	390.97 KiB $({\color{gray}0\%})$	391 KiB $({\color{gray}0\%})$	390.97 KiB $({\color{gray}0\%})$	1.14 MiB $({\color{gray}0\%})$	390.97 KiB $({\color{gray}0\%})$

bench/removeLast.bench.mo $({\color{gray}0\%})$

Remove items using removeLast

Vector and buffer are initialized with 100k items and then 70k items are removed one-by-one.

Instructions: ${\color{gray}0\%}$
Heap: ${\color{gray}0\%}$
Stable Memory: ${\color{gray}0\%}$
Garbage Collection: ${\color{gray}0\%}$

Instructions

	remove 70k
Vector	32_210_297 $({\color{gray}0\%})$
Buffer	31_716_422 $({\color{gray}0\%})$

Heap

	remove 70k
Vector	-136.8 KiB $({\color{gray}0\%})$
Buffer	-269.76 KiB $({\color{gray}0\%})$

Garbage Collection

	remove 70k
Vector	139.45 KiB $({\color{gray}0\%})$
Buffer	540.43 KiB $({\color{gray}0\%})$

bench/stable-memory.bench.mo $({\color{gray}0\%})$

Stable Memory and Region

Grow Region and store blobs in it

Instructions: ${\color{gray}0\%}$
Heap: ${\color{gray}0\%}$
Stable Memory: ${\color{gray}0\%}$
Garbage Collection: ${\color{gray}0\%}$

Instructions

	Region (fill 1/100)	Region (fill 1/50)	StableMemory
10 pages	65_117_422 $({\color{gray}0\%})$	260_557_814 $({\color{gray}0\%})$	2_861 $({\color{gray}0\%})$
100 pages	1_302_325_766 $({\color{gray}0\%})$	2_604_593_980 $({\color{gray}0\%})$	2_954 $({\color{gray}0\%})$
256 pages	3_334_080_226 $({\color{gray}0\%})$	6_668_025_672 $({\color{gray}0\%})$	3_704 $({\color{gray}0\%})$

Heap

	Region (fill 1/100)	Region (fill 1/50)	StableMemory
10 pages	296 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$	276 B $({\color{gray}0\%})$
100 pages	308 B $({\color{gray}0\%})$	308 B $({\color{gray}0\%})$	272 B $({\color{gray}0\%})$
256 pages	308 B $({\color{gray}0\%})$	308 B $({\color{gray}0\%})$	276 B $({\color{gray}0\%})$

Garbage Collection

	Region (fill 1/100)	Region (fill 1/50)	StableMemory
10 pages	2.38 MiB $({\color{gray}0\%})$	9.51 MiB $({\color{gray}0\%})$	336 B $({\color{gray}0\%})$
100 pages	47.55 MiB $({\color{gray}0\%})$	95.1 MiB $({\color{gray}0\%})$	340 B $({\color{gray}0\%})$
256 pages	121.73 MiB $({\color{gray}0\%})$	243.45 MiB $({\color{gray}0\%})$	340 B $({\color{gray}0\%})$

Stable Memory

	Region (fill 1/100)	Region (fill 1/50)	StableMemory
10 pages	8 MiB $({\color{gray}0\%})$	8 MiB $({\color{gray}0\%})$	8 MiB $({\color{gray}0\%})$
100 pages	8 MiB $({\color{gray}0\%})$	8 MiB $({\color{gray}0\%})$	0 B $({\color{gray}0\%})$
256 pages	16 MiB $({\color{gray}0\%})$	16 MiB $({\color{gray}0\%})$	16 MiB $({\color{gray}0\%})$