Chore/add testing infrastructure#25
Open
DanieleCremoniniOwkin wants to merge 8 commits intoZenWave360:masterfrom
Open
Chore/add testing infrastructure#25DanieleCremoniniOwkin wants to merge 8 commits intoZenWave360:masterfrom
DanieleCremoniniOwkin wants to merge 8 commits intoZenWave360:masterfrom
Conversation
Member
|
It looks good.. Do you want to merge this now or when some tests are aded? |
Author
|
I'd prefer now. Can you please fix the build problems I pasted? Thank you |
Member
|
there is also this error $ vsce package
ERROR You should not depend on 'vscode' in your 'dependencies'. Did you mean to add it to 'devDependencies'? |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testing infrastructure to the project
The project doesn't contain any test infrastructure, which prevents safe refactoring, is needed for bug fixing and is helpful for new developments.
I created the needed infrastructure.
One fake test is included.
To run the tests:
npm run testfrom the project root directory.
A caveat: compiling with
npm run compilegives some 12 errors such as:
several instances of:
this one
and
which could depend on my environment but I cannot resolve.