Conversation
- calculateCOP in the J_EAConversionHeatPump is now public. The BatteryForecast was still using an old formula for COP. - Added an Initialization method that checks if there are other flex assets present in any of the target gridconnections. If so, throws an exception. Heating Assets are an exception, there can be a single heating asset in each target gridconnection, which is stored in a map. - The Forecast method now looks for all profiles with EnergyCarrier Electricity and Heat. For heat it uses the above mentioned mapping to find the heating efficiency.
- Changed connectToJ_EA / removeTheJ_EA to now fill c_profileAssets with all J_EAProfiles, including J_EAConsumption and J_EAProduction. - Added a check in J_BatteryManagementPeakShavingForecast to skip the non electric heating assets. - Updated the HeatingManagement checks to align with the new c_profileAssets definition.
AteZenmo
deleted the
Profile_Assets_and_BatteryManagementPeakShavingForecast
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
must be merged together with: Zenmo/zero_Interface-Loader#262