Skip to content

ci: fix bridge-interop cachix skipPush condition never caching on main#199

Merged
YuanYuYuan merged 1 commit into
mainfrom
dev/cachix-ci
Jun 9, 2026
Merged

ci: fix bridge-interop cachix skipPush condition never caching on main#199
YuanYuYuan merged 1 commit into
mainfrom
dev/cachix-ci

Conversation

@YuanYuYuan

Copy link
Copy Markdown
Collaborator

Summary

The bridge-interop job had a different skipPush condition from every other CI job:

# Wrong — evaluates to true on push events (empty string != repo name)
skipPush: ${{ github.event.pull_request.head.repo.full_name != github.repository }}

# Fixed — consistent with all other jobs
skipPush: ${{ github.event_name == 'pull_request' }}

On a push event, github.event.pull_request is not set, so github.event.pull_request.head.repo.full_name resolves to an empty string. '' != 'ZettaScaleLabs/hiroz' is true, so skipPush was always true — the bridge-interop job never pushed derivations to the hiroz cachix cache, even on main branch runs.

Key Changes

  • Fix bridge-interop skipPush to use github.event_name == 'pull_request', matching all other jobs

@YuanYuYuan YuanYuYuan merged commit 3ee136b into main Jun 9, 2026
57 checks passed
@YuanYuYuan YuanYuYuan deleted the dev/cachix-ci branch June 9, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant