-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for js, ts and php test and coverage files #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Let me know if there's a more "bazel-y" way to do this. In my case, my test runs and coverage reports are currently happening outside of bazel. |
Thanks for the change! I like the sound of this - I've got a project which will soon need to get JS/TS tests and coverage tracked in SQ. I don't have any strong opposition to being able to import external reports. Your change should work with the new attrs in the same way as the coverage.dat pattern: do "stuff", and then use a filegroup to reference the generated files. Could you perhaps add a usage example of these attributes to the README? As a side note, I'm curious whether you've got the bazel-SQ environment to detect and use for analysis the TypeScript toolchain from rules_nodejs. I've not had a chance to investigate that myself. |
Any update on this ? |
@Mivr Unfortunately I've not had a chance to verify myself, but if this is working for you I'll be happy to merge it if you bring it up to date with the main branch and update the README. |
@KyleW you still need this? |
Nope! This was a couple of jobs ago. Feel free to close it out. |
@adincebic If you can finalize/merge the PR, I'll leverage it. |
Wondering whether this is needed in the first place since you can put all this stuff into your properties template file. I'll properly deal with this over the weekend. |
Extends the library to support a few of the properties one might want for TypeScript, JavaScript and PHP projects. Also adds support for generic test execution reports.