revert fmp4

[Zibbp]

No description provided.

[coderabbitai]

Walkthrough

Modified the ffmpeg movflags argument in DownloadTwitchLiveVideo function within internal/exec/exec.go. The argument was simplified from a concatenated string of multiple flags (faststart, frag_keyframe, empty_moov, default_base_moof) to only faststart.

Changes

Cohort / File(s)	Summary
FFmpeg Configuration internal/exec/exec.go	Simplified ffmpeg movflags argument in DownloadTwitchLiveVideo from "+faststart+frag_keyframe+empty_moov+default_base_moof" to "+faststart", removing frag_keyframe, empty_moov, and default_base_moof options

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	❓ Inconclusive	No description was provided, making it impossible to evaluate whether it relates to the changeset.	Add a description explaining why the fmp4 options (frag_keyframe, empty_moov, default_base_moof) are being reverted.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'revert fmp4' directly matches the changeset, which reverts fragmented mp4 (fmp4) options from the ffmpeg command.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-fmp4

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec2eee0 and dc6680b.

📒 Files selected for processing (1)

• internal/exec/exec.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: test
• GitHub Check: Build OCI Images (ubuntu-24.04, amd64, linux/amd64)
• GitHub Check: Build OCI Images (ubuntu-24.04-arm, arm64, linux/arm64)
• GitHub Check: Analyze (go)
• GitHub Check: lint

🔇 Additional comments (1)

internal/exec/exec.go (1)

254-254: Revert is clean and complete.

The change removes all fragmented MP4 flags, reverting DownloadTwitchLiveVideo to regular MP4 format with faststart. Both DownloadTwitchLiveVideo (line 254) and PostProcessVideo (line 435) now use identical movflags ("+faststart"), making the codebase consistent and removing all traces of the fMP4 format.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}