Skip to content

Feat/collection sharing frontend#155

Open
INagaty wants to merge 4 commits into
ZimengXiong:mainfrom
CalibtOS:feat/collection-sharing-frontend
Open

Feat/collection sharing frontend#155
INagaty wants to merge 4 commits into
ZimengXiong:mainfrom
CalibtOS:feat/collection-sharing-frontend

Conversation

@INagaty
Copy link
Copy Markdown

@INagaty INagaty commented Apr 27, 2026

PR request for the feature of collection sharing for frontend changes only
This pull request refactors the frontend/src/api/index.ts file to improve code readability and maintainability, and introduces a new Collection Sharing API. The main changes include consistent formatting, improved parameter handling, and the addition of several new functions for managing collection shares.

API Consistency and Formatting:

  • Refactored all API function parameters and object literals to use consistent formatting, including trailing commas and multi-line objects, improving readability and reducing future diff noise. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Standardized all string literals to use double quotes and improved code style throughout the file. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

New Feature: Collection Sharing API

  • Added a full suite of API functions for managing collection sharing, including getting, resolving, adding, updating, and removing collection shares. This includes new type imports and exports for CollectionShareRow, CollectionShareRole, and CollectionShareUser.

API Improvements and Bug Fixes:

  • Improved handling of API parameters and responses, including better destructuring, type safety, and error handling for drawing and sharing-related functions. [1] [2] [3]
  • Refactored authentication and CSRF handling logic for clarity and maintainability, including improved detection of public auth endpoints and better redirect logic. [1] [2] [3] [4]

These changes make the API layer more consistent and easier to extend, and add important new functionality for collection sharing. #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant