App Improvement#61
Merged
chcmedeiros merged 4 commits intomasterfrom Apr 17, 2026
Merged
Conversation
Collaborator
chcmedeiros
commented
Apr 17, 2026
chcmedeiros
commented
- Improve APDU checks
Introduce a `review_pending` flag to block new commands while the device is waiting for user approval. This prevents the host from mutating state or buffers during an asynchronous review window, addressing potential race conditions on transports like BLE.
Update Jest configuration to handle ESM-only dependencies like `get-port` and bump multiple devDependencies (including Zemu, Ledgerhq, and ESLint plugins) to their latest versions.
Update the main menu UI snapshots for various device models (Nano S, Nano S+, Nano X, Stax, Flex) to reflect recent changes.
chcmedeiros
force-pushed
the
improvement
branch
from
1951dfe to
89977e1
Compare
0xPxt
reviewed
Apr 17, 2026
Move the `review_pending` flag logic from individual command handlers into the central APDU dispatcher. This ensures the lock is consistently acquired at the start of processing and automatically released upon any command completion (success or error) or transport reset, reducing the risk of the dispatcher becoming permanently locked.
0xPxt
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.