Fix APDU dispatch and metadata parsing edge cases #288
Merged
Conversation
Update deps
6350896 to
264c84a
Compare
264c84a to
b73593b
Compare
chcmedeiros
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_check_addressenforces the same HD-path whitelist as SIGN and validates the declared path length.INS_SIGN_RAWrequiresblobLento match the buffered payload.addItemCount; rejects overflow.identifier_matches(exact len).INS_GET_ADDRrejects unsupported P2 curves.strcmpinstead of hardcoded-length.CheckMetadataHashmode byte bounds-checked before deref.parseMetadataEntryreleases recursion counter on every exit.pageIdxused in the loop condition.