Conversation
|
Warning Rate limit exceeded@abenso has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis change set introduces a new GitHub Actions workflow for C/C++ linting and formatting, adds a Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub
participant Runner
participant Linter
GitHub->>Runner: Trigger workflow (push/PR/manual)
Runner->>Runner: Checkout repo (recursive submodules)
Runner->>Runner: Install dependencies (clang-format, clang-tidy, etc.)
Runner->>Linter: Run cpp-linter-action
Linter->>Runner: Annotate, summarize, comment on lint results
Runner->>Runner: Fail workflow if lint/format errors detected
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
♻️ Duplicate comments (3)
tests/bip44path.cpp (1)
16-18: Same missing-header problem as commented in tests/asciify.cpp – address
centrally in the workflow to avoid per-file suppressions.tests/zxformat.cpp (1)
16-18: Duplicate of earlier comment: Google Mock headers are not available in the CI
image; installlibgmock-devor adjust the include..github/workflows/lint.yml (1)
11-14: Harden the workflow by scoping GITHUB_TOKEN permissionsThe CodeQL warning is valid: jobs run with full write permissions by default.
Add an explicit, minimalpermissions:block to the job (or workflow) level:jobs: lint: + permissions: + contents: read # required by checkout + pull-requests: write # needed for inline annotations/thread-comments runs-on: ubuntu-latestThis mitigates the risk of privilege escalation from compromised third-party
actions.
🧹 Nitpick comments (2)
tests/hexutils.cpp (1)
21-21: Include-order nit (optional)If you keep the quoted form, group project headers after STL and before third-party (
gmock) headers to follow common conventions..github/workflows/lint.yml (1)
18-41: Minor YAML hygiene – strip trailing whitespace & ensure final EOL
yaml-lintflagged three trailing-space lines and a missing newline at EOF.
They don’t break the workflow but will keep failing lint:- submodules: recursive␠ + submodules: recursive … - + … - +Also append a newline after Line 46.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (17)
.github/workflows/lint.yml(1 hunks)Makefile(2 hunks)evm/crypto_evm.c(1 hunks)evm/parser_impl_evm.c(1 hunks)evm/tx_evm.h(1 hunks)include/zxversion.h(1 hunks)src/zxmacros.c(1 hunks)tests/asciify.cpp(1 hunks)tests/base64.cpp(1 hunks)tests/bech32.cpp(1 hunks)tests/bip44path.cpp(1 hunks)tests/buffering_tests.cpp(1 hunks)tests/doubledabble.cpp(3 hunks)tests/hexutils.cpp(1 hunks)tests/macros.cpp(1 hunks)tests/sigutils.cpp(4 hunks)tests/zxformat.cpp(1 hunks)
🧰 Additional context used
🪛 GitHub Check: lint
tests/hexutils.cpp
[failure] 17-17: tests/hexutils.cpp:17:10 [clang-diagnostic-error]
'hexutils.h' file not found
tests/bip44path.cpp
[failure] 16-16: tests/bip44path.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
tests/doubledabble.cpp
[failure] 17-17: tests/doubledabble.cpp:17:10 [clang-diagnostic-error]
'hexutils.h' file not found
tests/base64.cpp
[failure] 16-16: tests/base64.cpp:16:10 [clang-diagnostic-error]
'base64.h' file not found
tests/asciify.cpp
[failure] 16-16: tests/asciify.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
tests/bech32.cpp
[failure] 16-16: tests/bech32.cpp:16:10 [clang-diagnostic-error]
'bech32.h' file not found
tests/sigutils.cpp
[failure] 17-17: tests/sigutils.cpp:17:10 [clang-diagnostic-error]
'sigutils.h' file not found
tests/buffering_tests.cpp
[failure] 17-17: tests/buffering_tests.cpp:17:10 [clang-diagnostic-error]
'buffering.h' file not found
tests/zxformat.cpp
[failure] 16-16: tests/zxformat.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
tests/macros.cpp
[failure] 16-16: tests/macros.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
🪛 GitHub Check: CodeQL
.github/workflows/lint.yml
[warning] 13-46: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
🪛 YAMLlint (1.37.1)
.github/workflows/lint.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (c-cpp)
🔇 Additional comments (17)
evm/tx_evm.h (1)
38-38: Formatting-only change is fineOnly an extra space was added after the
#endif. No functional impact – looks good.include/zxversion.h (1)
20-20: Version bump acknowledgedPatch version increment from 0 → 1 reflects the non-functional formatting & tooling updates. No issues.
evm/crypto_evm.c (1)
183-184: LGTM! Formatting improvement enhances readability.The indentation alignment of the
&evm_chain_codeparameter improves code consistency and readability.src/zxmacros.c (1)
31-32: LGTM! Improved formatting of infinite loop.Expanding the infinite loop to multiple lines with an explicit semicolon improves readability and code style consistency.
evm/parser_impl_evm.c (1)
17-327: LGTM! Comprehensive formatting cleanup enhances codebase consistency.The extensive formatting improvements throughout the file enhance readability and align with standard C coding conventions. All functional logic remains unchanged.
Makefile (2)
4-4: LGTM! Proper addition to phony targets.Adding
formatto the.PHONYdeclaration ensures the target runs correctly even if a file named "format" exists.
31-32: LGTM! Useful formatting target for local development.The new
formattarget provides a convenient way for developers to apply consistent code formatting locally. The implementation correctly targets the appropriate directories and file extensions, and usesclang-format -ifor in-place formatting.tests/buffering_tests.cpp (1)
1-205: LGTM! Formatting improvements enhance test readability.The comprehensive formatting cleanup improves code consistency and test structure while maintaining all functional logic.
tests/bech32.cpp (3)
2-15: LGTM: License header formatting is consistent.The license header has been properly formatted with consistent leading asterisks and spacing.
21-148: LGTM: Test formatting is consistent and comprehensive.The test cases have been properly unindented and reformatted for consistency. All test logic appears unchanged, maintaining coverage for:
- Basic Bech32/Bech32M encoding functionality
- Error handling for oversized inputs (out of bounds)
- Buffer size validation (buffer too small)
- Both encoding variants (BECH32 and BECH32M)
The explicit namespace closing comment improves readability.
16-19: bech32.h Header Availability VerifiedThe
bech32.hfile was found atinclude/bech32.h, so the<bech32.h>include intests/bech32.cppis valid and no missing dependencies were detected.– No further action required.
tests/macros.cpp (6)
2-15: LGTM: License header formatting is consistent.The license header has been properly formatted matching the project-wide style improvements.
21-30: LGTM: Hex string conversion test is correct.The
array_to_hexstrtest properly validates hex conversion with appropriate buffer management and null termination checks.
32-55: LGTM: Fixed-point formatting tests are comprehensive.The
fpuint64_to_strtests cover various decimal place scenarios and validate the correct placement of decimal points. The test cases demonstrate proper understanding of fixed-point representation.
102-185: LGTM: Excellent boundary and error condition testing.The error condition tests (
fpstr_to_str_BAD_*) are particularly valuable as they validate:
- Buffer overflow protection
- Precision limit handling
- Output buffer size constraints
- Graceful "ERR" responses for invalid scenarios
This thorough error testing improves code reliability.
327-413: LGTM: Integer conversion tests cover edge cases well.The
UINT32_TO_STRandINT64_TO_STRtest suites comprehensively validate:
- Zero and boundary values (min/max)
- Buffer size requirements
- Positive and negative numbers
- Proper error handling for insufficient buffer space
The use of
std::numeric_limitsfor boundary testing is a good practice.
415-535: LGTM: String-to-integer parsing tests are thorough.The
STR_TO_INT8andSTR_TO_INT64test suites provide excellent coverage for:
- Boundary value validation (min/max ranges)
- Invalid input handling (non-numeric characters)
- Overflow/underflow detection
- Proper error flag usage
The tests appropriately validate both successful parsing and error conditions.
| #include <gmock/gmock.h> | ||
| #include <zxmacros.h> | ||
| #include <zxformat.h> | ||
| #include <zxmacros.h> |
There was a problem hiding this comment.
Install Google Test/Mock headers to unblock clang-tidy include resolution
clang-tidy inside the new linter job errors out with
'gmock/gmock.h' file not found.
The test targets rely on Google Mock, but the workflow only installs clang-*
tooling, not the headers.
Either:
- Extend the
apt-get installlist withlibgtest-dev libgmock-dev
(preferred, keeps the test code unchanged), or - Switch the include to
<gtest/gtest.h>if you only need gtest macros and
not gmock (verify first).
Without one of these, the linter workflow will always fail on every PR.
🧰 Tools
🪛 GitHub Check: lint
[failure] 16-16: tests/asciify.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
🤖 Prompt for AI Agents
In tests/asciify.cpp around lines 16 to 18, the include directive for
'gmock/gmock.h' causes clang-tidy to fail due to missing Google Mock headers. To
fix this, update the CI workflow to install the 'libgtest-dev' and
'libgmock-dev' packages via apt-get so the headers are available, or
alternatively, if only Google Test macros are needed, replace the include with
'gtest/gtest.h'. The preferred fix is to install the missing packages to keep
the test code unchanged.
| #include "base64.h" | ||
|
|
||
| #include <gmock/gmock.h> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Header cannot be found by the linter – supply include path or install dev package
base64.h lives in the repository but the linter compiles each file in
isolation and therefore does not know the include search-path.
Add the repo root (or src/ if that’s where the header sits) to
extra-arg: "-I$GITHUB_WORKSPACE" when calling the linter, or pass a
compile_commands.json. Otherwise every file that includes project headers
will keep triggering 'file not found' diagnostics.
🧰 Tools
🪛 GitHub Check: lint
[failure] 16-16: tests/base64.cpp:16:10 [clang-diagnostic-error]
'base64.h' file not found
🤖 Prompt for AI Agents
In tests/base64.cpp around lines 16 to 18, the linter cannot find the base64.h
header because it lacks the proper include path. To fix this, update the linter
configuration to add the repository root or the src/ directory to the include
search path by passing extra-arg: "-I$GITHUB_WORKSPACE" or provide a
compile_commands.json file so the linter knows where to find project headers and
stops reporting 'file not found' errors.
| ********************************************************************************/ | ||
|
|
||
| #include "gtest/gtest.h" | ||
| #include "buffering.h" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fix missing header file compilation error.
The #include "buffering.h" is causing a compilation failure as indicated by the static analysis. This will prevent the tests from building successfully.
Verify the location and availability of the buffering.h header file:
🏁 Script executed:
#!/bin/bash
# Description: Find the buffering.h header file and check if it exists
# Expected: Should find the header file location or confirm it's missing
echo "Searching for buffering.h in the repository..."
fd -t f -e h "buffering"
echo -e "\nChecking if buffering.h exists in common include paths..."
fd -t f "buffering.h"
echo -e "\nLooking for buffering-related files..."
fd -t f "buffering"Length of output: 495
Add test include path for buffering.h
The #include "buffering.h" in tests/buffering_tests.cpp is correct—buffering.h lives at include/buffering.h. The compilation failure simply means the compiler isn’t looking in include/. Please update your test build configuration (e.g., CMakeLists.txt) to add the include/ directory to the test target’s include paths. For example:
# In your CMakeLists.txt for the tests target
target_include_directories(buffering_tests PRIVATE
${CMAKE_SOURCE_DIR}/include
)This ensures the compiler can locate buffering.h when building the tests.
🧰 Tools
🪛 GitHub Check: lint
[failure] 17-17: tests/buffering_tests.cpp:17:10 [clang-diagnostic-error]
'buffering.h' file not found
🤖 Prompt for AI Agents
In tests/buffering_tests.cpp at line 17, the include directive for "buffering.h"
fails because the compiler does not search the include/ directory by default. To
fix this, update the test build configuration file (such as CMakeLists.txt) to
add the include/ directory to the test target's include paths using
target_include_directories with the path ${CMAKE_SOURCE_DIR}/include. This will
allow the compiler to locate buffering.h during test compilation.
| #include <hexutils.h> | ||
|
|
||
| #include "bignum.h" |
There was a problem hiding this comment.
hexutils.h still missing from include search path
Even with the angle-bracket form, hexutils.h cannot be located when building this test. Either:
- Add the appropriate include directory (e.g.,
-Iinclude) to the test build; or - Use a relative path that resolves (
#include "../include/hexutils.h").
Without this the new linter job – and any future build – will fail.
🧰 Tools
🪛 GitHub Check: lint
[failure] 17-17: tests/doubledabble.cpp:17:10 [clang-diagnostic-error]
'hexutils.h' file not found
🤖 Prompt for AI Agents
In tests/doubledabble.cpp around lines 17 to 19, the include directive for
hexutils.h uses angle brackets but the header file is not found in the include
search path during build. Fix this by either adding the directory containing
hexutils.h to the test build include paths (e.g., adding -Iinclude to the
compiler flags) or by changing the include directive to use a relative path that
correctly locates the file, such as #include "../include/hexutils.h".
| #include "hexutils.h" | ||
|
|
||
| #include <string> | ||
|
|
||
| #include "hexutils.h" | ||
| #include "gmock/gmock.h" |
There was a problem hiding this comment.
hexutils.h cannot be found – switch back to angle-bracket include or fix include-path
The linter error confirms the compiler can no longer locate the header. Using quotes makes the include relative to the current directory, whereas the project previously relied on the header being in the global include path.
-#include "hexutils.h"
+#include <hexutils.h>Alternatively, add the directory that contains hexutils.h to the compiler’s include paths for the test target.
Failing to address this will break every CI build.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #include "hexutils.h" | |
| #include <string> | |
| #include "hexutils.h" | |
| #include "gmock/gmock.h" | |
| #include <hexutils.h> | |
| #include <string> | |
| #include "gmock/gmock.h" |
🧰 Tools
🪛 GitHub Check: lint
[failure] 17-17: tests/hexutils.cpp:17:10 [clang-diagnostic-error]
'hexutils.h' file not found
🤖 Prompt for AI Agents
In tests/hexutils.cpp around lines 17 to 21, the include directive for
"hexutils.h" uses quotes which causes the compiler to look relative to the
current directory and fails to find the header. Change the include directive to
use angle brackets instead, i.e., #include <hexutils.h>, or alternatively,
update the test target's compiler include paths to include the directory
containing hexutils.h so the header can be found globally.
| #include <gmock/gmock.h> | ||
| #include <zxmacros.h> | ||
| #include <zxformat.h> | ||
| #include <zxmacros.h> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify gmock availability.
Static analysis reports that gmock/gmock.h cannot be found. Please ensure Google Mock is properly installed and accessible in the include path.
🏁 Script executed:
#!/bin/bash
# Description: Check for gmock/gtest availability and include paths
echo "Checking for gmock headers..."
fd -t f "gmock.h" 2>/dev/null || echo "gmock.h not found"
echo -e "\nChecking for gtest/gmock in common locations..."
find /usr -name "*gmock*" -o -name "*gtest*" 2>/dev/null | head -10 || echo "Not found in /usr"
echo -e "\nChecking if this is a CMake project with find_package..."
fd -t f "CMakeLists.txt" --exec grep -l "GTest\|gmock" {}Length of output: 461
🏁 Script executed:
#!/bin/bash
# Inspect how GTest/GMock are configured in CMakeLists.txt
echo "Searching for GTest/GMock configuration in CMakeLists.txt..."
grep -nE '(find_package|target_link_libraries|include_directories).*(GTest|gmock)' -C3 CMakeLists.txtLength of output: 353
🏁 Script executed:
#!/bin/bash
# Locate where tests/macros.cpp is added and how GMock is linked
echo "Searching for macros.cpp references:"
grep -R -n "macros\.cpp" .
echo -e "\nInspecting CMakeLists.txt for test target linkage:"
grep -R -nE "add_executable|target_link_libraries" --include CMakeLists.txt .Length of output: 457
🏁 Script executed:
#!/bin/bash
# Display CMake test target configuration to verify GMock linkage
sed -n '55,85p' CMakeLists.txtLength of output: 511
Link and Configure Google Mock in CMake
GMock isn’t currently found or linked—even though tests/macros.cpp includes <gmock/gmock.h>, the CMake setup only finds and links GTest. You need to ensure GMock headers are on the include path and the test executable links against the GMock targets.
Locations to update:
- In
CMakeLists.txtaround the existing find step (currently at line 40):- Change
to
find_package(GTest CONFIG REQUIRED)
find_package(GTest CONFIG REQUIRED COMPONENTS gmock gmock_main)
- Change
- In the
target_link_librariesforzxlib_tests(around line 72):- Add
GTest::gmock_main(and/orGTest::gmock) alongsideGTest::gtest_main, for example:target_link_libraries(zxlib_tests PRIVATE GTest::gtest_main
- Add
-
GTest::gmock_main zxlib)
After these changes, rerun CMake to verify <gmock/gmock.h> is found and the test target links correctly.
🧰 Tools
🪛 GitHub Check: lint
[failure] 16-16: tests/macros.cpp:16:10 [clang-diagnostic-error]
'gmock/gmock.h' file not found
🤖 Prompt for AI Agents
In CMakeLists.txt around lines 40 and 72, update the find_package call to
include GMock components by changing find_package(GTest CONFIG REQUIRED) to
find_package(GTest CONFIG REQUIRED COMPONENTS gmock gmock_main). Then, in the
target_link_libraries section for zxlib_tests near line 72, add
GTest::gmock_main alongside GTest::gtest_main to ensure GMock headers are
included and linked properly. After these changes, rerun CMake to confirm the
test executable finds and links GMock correctly.
| #include "sigutils.h" | ||
|
|
||
| #include "gmock/gmock.h" | ||
| #include <string> | ||
| #include <hexutils.h> |
There was a problem hiding this comment.
sigutils.h not resolved – header include style/path needs correction
sigutils.h now uses quotes, causing the same “file not found” error reported by clang-tidy. Use angle brackets or fix the include path:
-#include "sigutils.h"
+#include <sigutils.h>Make sure the build system for the tests has the directory containing sigutils.h on the include search list.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #include "sigutils.h" | |
| #include "gmock/gmock.h" | |
| #include <string> | |
| #include <hexutils.h> | |
| #include <sigutils.h> | |
| #include <hexutils.h> |
🧰 Tools
🪛 GitHub Check: lint
[failure] 17-17: tests/sigutils.cpp:17:10 [clang-diagnostic-error]
'sigutils.h' file not found
🤖 Prompt for AI Agents
In tests/sigutils.cpp around lines 17 to 19, the include directive for
sigutils.h uses quotes but the file is not found, causing a build error. Change
the include to use angle brackets or adjust the include path so the compiler can
locate sigutils.h. Also verify that the test build configuration includes the
directory containing sigutils.h in its include search paths.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
.github/workflows/lint.yml (2)
11-14: Add explicitpermissionsblock forGITHUB_TOKENThe workflow uses the default token with full write permissions. Add an explicit, least-privilege
permissionssection (e.g.,contents: read) at the job or workflow level.
19-26: Include Google Test/Mock dev packages so clang-tidy can parse tests
libgtest-devandlibgmock-devare still missing from theapt-get installlist, which breaks header resolution inside test files.sudo apt-get install -y \ build-essential \ cmake \ clang-format \ clang-tidy \ + libgtest-dev \ + libgmock-dev
🧹 Nitpick comments (4)
.github/workflows/lint.yml (4)
18-18: Remove trailing whitespaceYAMLlint flags trailing spaces on this line.
27-27: Remove trailing whitespaceSame lint warning as above for Line 27.
42-42: Remove trailing whitespaceTrailing spaces also appear on Line 42.
47-47: Add a newline at EOFA final newline is required by POSIX tools and avoids YAMLlint
new-line-at-end-of-fileerrors.+
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
.github/workflows/lint.yml(1 hunks)
🧰 Additional context used
🪛 GitHub Check: CodeQL
.github/workflows/lint.yml
[warning] 13-47: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
🪛 YAMLlint (1.37.1)
.github/workflows/lint.yml
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
[error] 47-47: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint
- GitHub Check: Analyze (c-cpp)
- GitHub Check: lint
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (15)
.github/workflows/lint.yml(1 hunks)Makefile(2 hunks)app/ui/view.c(1 hunks)app/ui/view.h(2 hunks)app/ui/view_inspect_x.c(5 hunks)app/ui/view_nano.h(1 hunks)app/ui/view_nano_inspect.c(4 hunks)app/ui/view_nbgl.c(3 hunks)app/ui/view_s.c(17 hunks)app/ui/view_x.c(3 hunks)include/base64.h(1 hunks)include/bech32.h(1 hunks)include/bignum.h(1 hunks)include/view_templates.h(5 hunks)include/zxmacros.h(1 hunks)
✅ Files skipped from review due to trivial changes (12)
- include/zxmacros.h
- app/ui/view_nano.h
- Makefile
- include/base64.h
- app/ui/view_nbgl.c
- app/ui/view_x.c
- include/bignum.h
- app/ui/view_inspect_x.c
- include/bech32.h
- app/ui/view_nano_inspect.c
- app/ui/view_s.c
- include/view_templates.h
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/lint.yml
[error] 21-21: trailing spaces
(trailing-spaces)
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 47-47: trailing spaces
(trailing-spaces)
[error] 52-52: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (c-cpp)
🔇 Additional comments (3)
.github/workflows/lint.yml (1)
33-52: LGTM! Comprehensive linting configuration.The cpp-linter configuration is well-structured with appropriate:
- Include paths covering all source directories
- Exclusions for build artifacts and configuration directories
- Proper failure handling to enforce formatting standards
- Integration with GitHub's annotation and commenting features
This addresses the previous concerns about missing dependencies and provides robust CI enforcement for code formatting.
app/ui/view.h (1)
123-124: LGTM! Consistent function declaration formatting.The consolidation of the multi-line function declaration into a single line improves readability and consistency with the project's formatting standards. No functional changes were made.
app/ui/view.c (1)
65-66: LGTM! Consistent function definition formatting.The consolidation of the multi-line function definition into a single line maintains consistency with the corresponding header file change and improves code formatting uniformity. The function logic and parameters remain unchanged.
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
|
|
There was a problem hiding this comment.
Fix YAML formatting issues.
Static analysis detected several formatting issues that should be addressed:
-
+
-
+
-
+Also add a newline at the end of the file:
echo "Linter or formatter failed!"
exit 1
+Also applies to: 32-32, 47-47, 52-52
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 21-21: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
In .github/workflows/lint.yml at lines 21, 32, 47, and 52, fix the YAML
formatting issues by correcting indentation, spacing, or syntax errors as
indicated by static analysis. Also, ensure there is a newline character at the
end of the file to comply with standard file formatting conventions.
abenso
force-pushed
the
chore/format
branch
2 times, most recently
from
8c0594b to
a4a0611
Compare
2 participants
🔗 zboto Link
Summary by CodeRabbit
Chores
Style
Tests