many: Change style of ifdef of Windows vs Unix #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were many instances of an ifdef idiom checking for one of many Unix-like systems, and an else for Windows. This idiom fails to build on a new Unix-like system and needs significant edits. Replace most instances of the list of systems with a "if this system is not windows" and an else (for windows), intending to have no code change on any system in the prior list, and extending portability to Unix-like systems not in the prior list. Another idiom is "if this is windows", followed by an else or if for a list of Unix-like systems. Replace this with a simple "if windows else". As part of this cleanup, in several places, an else clause -- for systems that aren't in the list and aren't windows -- was removed. This never made sense and is a bugfix. In the one case where there is a correct "if linux or freebsd" (ethernet.h include), explain why it's there and implicitly why it's not a pattern to be extended to every new system.
Author
|
I think this is now at the point where it makes sense for review and merging. The ifdef situation was more complicated than I understood at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many instances of an ifdef idiom checking for one of many Unix-like systems, and an else for Windows. This idiom fails to build on a new Unix-like system and needs significant edits.
Replace the list of systems with a "if this system is not windows" and an else, intending to have no code change on any system in the prior list, and extending portability to Unix-like systems not in the prior list.
In several places, an else clause -- for systems that aren't in the list and aren't windows -- was removed.
This commit (and dropping extending the conditionals to NetBSD) has survived build testing on NetBSD, and I'm running it on NetBSD/aarch64, apparently ok.