Skip to content

feat(header): Chevron right for collapsed - chevron down for expanded #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simpler1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(header): Chevron right for collapsed - chevron down for expanded #4318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/skins/classic/includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ function getNormalNavBarHTML($running, $user, $bandwidth_options, $view, $skin)
</nav><!-- End First Navbar -->

<nav class="navbar navbar-expand-md justify-content-center" id="navbar-two"
<?php echo ( isset($_COOKIE['zmHeaderFlip']) and $_COOKIE['zmHeaderFlip'] == 'down' ) ? 'style="display:none;"' : '' ?>
<?php echo ( isset($_COOKIE['zmHeaderFlip']) and $_COOKIE['zmHeaderFlip'] == 'hidden' ) ? 'style="display:none;"' : '' ?>
>
<div class="container-fluid" id="panel">
<?php
Expand Down Expand Up @@ -889,7 +889,7 @@ function getMapHTML($view) {
function getHeaderFlipHTML() {
$result = '';

$header = ( isset($_COOKIE['zmHeaderFlip']) and $_COOKIE['zmHeaderFlip'] == 'down') ? 'down' : 'up';
$header = ( isset($_COOKIE['zmHeaderFlip']) and $_COOKIE['zmHeaderFlip'] == 'shown') ? 'down' : 'right';
$result .= '<li id="getHeaderFlipHTML" class="nav-item dropdown"><a class="nav-link" href="#"><i id="flip" class="material-icons md-18" style="display: inline-block;">keyboard_arrow_' .$header. '</i></a></li>'.PHP_EOL;

return $result;
Expand Down
10 changes: 5 additions & 5 deletions web/skins/classic/js/skin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,12 @@ if ( currentView != 'none' && currentView != 'login' ) {
function navbarTwoFlip() {
$j("#navbar-two").slideToggle("slow");
const flip = $j("#flip");
if ( flip.html() == 'keyboard_arrow_up' ) {
flip.html('keyboard_arrow_down');
setCookie('zmHeaderFlip', 'down');
if ( flip.html() == 'keyboard_arrow_down' ) {
flip.html('keyboard_arrow_right');
setCookie('zmHeaderFlip', 'hidden');
} else {
flip.html('keyboard_arrow_up');
setCookie('zmHeaderFlip', 'up');
flip.html('keyboard_arrow_down');
setCookie('zmHeaderFlip', 'shown');
}
}

Expand Down